Skip to content

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Sep 27, 2025

Specifically:

  1. I renamed the old llvm-as which printed with optimization as llvm-as-opt and made llvm-as just test IRGen. That is really the true reason that I created this utility many years ago: to test how IRGen lowers specific SIL instruction sequences. How LLVM optimizes such sequences once lowered is a different problem. I updated the one test that used sil-llvm-gen and required optimizations to use llvm-as-opt so that the tests output did not change.
  2. I found that we were not running Sema before parsing SIL like sil-opt does. I fixed that.
  3. I ported the LangOpts flags from sil-opt to sil-llvm-gen. It had just atrophied.

I am going to use this to test a new SIL instruction with special IRGen behavior. Really we should be testing more SIL instructions like this (that is directly) from SIL to IRGen.

@gottesmm gottesmm requested a review from jckarter as a code owner September 27, 2025 19:37
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm gottesmm enabled auto-merge September 27, 2025 19:37
…run.

Specifically, I renamed the old llvm-as which printed with optimization as
llvm-as-opt and made llvm-as just test IRGen. That is really the true reason
that I created this utility many years ago: to test how IRGen lowers specific
SIL instruction sequences. How LLVM optimizes such sequences once lowered is a
different problem. I updated the one test that used sil-llvm-gen and required
optimizations to use llvm-as-opt so that the tests output did not change.
@gottesmm gottesmm force-pushed the pr-cd8090d1fb5e8fd9fbb2ae8dbdd5eb34dc24df99 branch from eeb1f88 to 1560d3d Compare September 27, 2025 19:42
@gottesmm gottesmm changed the title [sil-llvm-gen] Add support for emitting IR before LLVM optimizations run [sil-llvm-gen] Some small fixes before I use sil-llvm-gen to test Concurrency functionality. Sep 27, 2025
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

1 similar comment
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm gottesmm force-pushed the pr-cd8090d1fb5e8fd9fbb2ae8dbdd5eb34dc24df99 branch from 1560d3d to f8eab89 Compare September 29, 2025 17:36
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm gottesmm force-pushed the pr-cd8090d1fb5e8fd9fbb2ae8dbdd5eb34dc24df99 branch from f8eab89 to 739bf00 Compare September 29, 2025 18:12
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm gottesmm force-pushed the pr-cd8090d1fb5e8fd9fbb2ae8dbdd5eb34dc24df99 branch from 739bf00 to ca2fb09 Compare September 29, 2025 19:59
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm gottesmm merged commit 8c9f291 into swiftlang:main Sep 30, 2025
3 checks passed
@gottesmm gottesmm deleted the pr-cd8090d1fb5e8fd9fbb2ae8dbdd5eb34dc24df99 branch September 30, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant