Provide an implementation of swift_stdlib_random() derived from std::random_device.
#84542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d::random_device`. This PR provides an alternate platform-agnostic implementation of `swift_stdlib_random()` based on C++11's `std::random_device`. This implementation should be portable even to Embedded Swift, with the significant caveat that there is no way to know at compile time if the random numbers produced are _actually_ non-deterministic. (They _should_ be, but if the current implementation has no suitable RNG, the API doesn't provide a way to detect that statically.)
grynspan
added
improvement
standard library
|
@swift-ci test |
|
@swift-ci test |
|
Embedded Swift doesn’t currently use |
|
The embedded version is defined here swift/stdlib/public/core/EmbeddedRuntime.swift Lines 536 to 541 in b15e24a |
|
Thanks. I posted this for the sake of discussion. |
|
To clarify: there was a hallway discussion about needing an implementation of |
Math is hard.
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an alternate platform-agnostic implementation of
swift_stdlib_random()based on C++11'sstd::random_device. This implementation should be portable even to Embedded Swift, with the significant caveat that there is no way to know at compile time if the random numbers produced are actually non-deterministic. (They should be, but if the current implementation has no suitable RNG, the API doesn't provide a way to detect that statically.)