Model the stack allocation of async let begin/finish in SIL #84528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmccall
requested review from
a team,
eeckstein,
jckarter,
AnthonyLatsis,
adrian-prantl,
ktoso,
kavon,
hborla,
slavapestov,
xedin and
compnerd
as code owners
|
@swift-ci Please test |
functions. These were introduced in an early draft implementation of async let, but never used by a released compiler. They are not used as symbols by any app binaries. There's no reason to keep carrying them. While I'm at it, dramatically improve the documentation of the remaining async let API functions.
arguments to the CallEmission.
rjmccall
force-pushed
the
async-let-runtime-realism
branch
from
6a92685 to
854242e
Compare
|
@swift-ci Please test |
Reflect the potential stack allocation of the begin/finish pair in SIL, which should prevent the optimizer from trying to move stack allocations around them. I'm not actually sold that the runtime *has* to do a stack allocation here, because it only really does it because it creates a result buffer in the future that it should be able to avoid. But it's undisputable that it currently does so, and we may come up with good reasons for it to continue to do so even if we remove the current allocation, so modeling the allocation is the right thing to do. Fixes rdar://109850951
rjmccall
force-pushed
the
async-let-runtime-realism
branch
from
854242e to
8cd55ec
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not actually sold that the runtime has to do a stack allocation here, because it only really does it because it creates a result buffer in the future that it should be able to avoid. But it's indisputable that it currently does so, and we may come up with good reasons for it to continue to do so even if we remove the current allocation, so modeling the allocation is the right thing to do.
Fixes rdar://109850951