[Interop] Bridging cleanup #84527
Open
[Interop] Bridging cleanup #84527
+13
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inheriting some class named `NonCopyable` is not what makes a type noncopyable. Explicitly use SWIFT_NONCOPYABLE in the example instead.
hnrklssn
requested review from
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun,
j-hui,
fahadnayyar and
susmonteiro
as code owners
|
@swift-ci please smoke test |
egorzhdan
reviewed
Sep 26, 2025
| /// ```c++ | ||
| /// class SWIFT_SHARED_REFERENCE(retainSharedObject, releaseSharedObject) | ||
| /// SharedObject : NonCopyable, IntrusiveReferenceCounted<SharedObject> { | ||
| /// class SWIFT_SHARED_REFERENCE(retainSharedObject, releaseSharedObject) SWIFT_NONCOPYABLE |
There was a problem hiding this comment.
Does SWIFT_NONCOPYABLE actually have any effect when applied to reference types?
There was a problem hiding this comment.
good point actually
There was a problem hiding this comment.
Then I'm not sure I follow the intent of the example 🤔
There was a problem hiding this comment.
I think we can remove the noncopyable here entirely, just to avoid the (incorrect) assumption that a foreign reference type must be annotated as a noncopyable type explicitly.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup in
swift/bridging.