[cxx-interop] Make imported enum members inherit the access of their parent #84522
+304
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parent This patch relaxes the access check for members of imported inherited nested enums. Without it, those members become impossible to inherit, which largely defeats the purpose of importing them in the first place. rdar://160803362
j-hui
requested review from
zoecarver,
egorzhdan,
Xazax-hun,
fahadnayyar,
susmonteiro,
hnrklssn,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
|
@swift-ci please test |
j-hui
commented
Sep 26, 2025
|
|
||
| AccessInversionTestSuite.test("usePrivateEnum") { | ||
| let e = Leaky.AliasToPrivateEnum(rawValue: 0)! | ||
| let e = Leaky.AliasToPrivateEnum(rawValue: 0) |
There was a problem hiding this comment.
I'm not actually sure why this changed/had to be written like this before. But this seems like the right behavior to me, since the initializer does not return an optional.
hnrklssn
reviewed
Sep 26, 2025
test/Interop/Cxx/class/access/non-public-nested-enum-typecheck.swift
Outdated
Show resolved
Hide resolved
hnrklssn
reviewed
Sep 26, 2025
hnrklssn
reviewed
Sep 26, 2025
test/Interop/Cxx/class/access/access-inversion-typechecker.swift
Outdated
Show resolved
Hide resolved
egorzhdan
approved these changes
Sep 26, 2025
hnrklssn
reviewed
Sep 26, 2025
|
@swift-ci please test |
hnrklssn
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch relaxes the access check for members of imported inherited nested enums. Without it, those members become impossible to inherit, which largely defeats the purpose of importing them in the first place.
rdar://160803362