[5.5] Cherry-pick a change from main to handle missing mandatory tail call optimizations #40451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If target doesn't support musttail (e.g. WebAssembly), the function passed to coro.end.async can return control back to the caller. So the frontend should emit 'ret void' instead of unreachable after the coro.end.async intrinsic call to allow such situation. (cherry picked from commit 671ce74)
The change in 39680 impacts more than WebAssembly, but it did not update the tests for impacted targets. (cherry picked from commit 3df2531)
|
CC: @DougGregor |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test macOS platform |
tkremenek
approved these changes
Dec 7, 2021
|
@aschwaighofer can you quickly review this to confirm this is limited in scope and kosher to pull in a dot-dot release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks a change from main that ensures that async returns use
ret voidrather thanunreachableon targets which do not support the LLVMmusttailinstruction. Unfortunately, Windows does not support themusttailinstruction as the PEI does not handle the lowering of the frame properly yet.