Make swift-syntax build without warnings #2558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/no-warnings-in-swiftsyntax
branch
from
739e0f9 to
9e61008
Compare
|
@swift-ci Please test |
|
@swift-ci Please test |
bnbarham
approved these changes
Mar 25, 2024
ahoppen
force-pushed
the
ahoppen/no-warnings-in-swiftsyntax
branch
from
9e61008 to
fcb117e
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
rintaro
approved these changes
Mar 25, 2024
…ed version and deprecate a typealias This allows us to still use the underscored version internally (eg. when matching the syntax node kind during the creation of a `SyntaxEnum` and keep swift-syntax building without warnings.
ahoppen
force-pushed
the
ahoppen/no-warnings-in-swiftsyntax
branch
from
fcb117e to
24c8f91
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main problem here was that we can’t just deprecate syntax nodes since swift-syntax needs to still be able to use them internally (eg. when creating
SyntaxEnumcases foras(SyntaxEnum.self)). What we do instead, is to have an underscored node that is not deprecated and deprecate a public typealias from the non-underscored version to the underscored version of the node.While doing this, I also realized that the
SyntaxKindcompatibility layer didn’t add deprecation warnings and that we were still using some of them.And finally, we need to annotate
Syntax.Info.infoasnonisolated(unsafe). It already had a comment that detailed when it might be modified.