Switching back _dispatch_operation_perform to use posix_memalign from aligned_malloc #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci please smoke test |
|
@swift-ci test linux |
|
Sorry, only seeing this now. I will add this commit to #827 if and when you get this merged. |
rokhinip
approved these changes
May 14, 2024
|
@PriyaAvhad, this pull will need to be rebased before it can be merged. |
|
Needs a rebase but lgtm |
ktoso
approved these changes
May 16, 2024
|
@PriyaAvhad, does #805 need to be reverted or is this one change enough? |
|
The thread sanitizer complaint was about just the file I have modified in this PR; but, I agree with you that it would be much cleaner to revert #805 instead. |
…ar places to use posix_memalign from aligned_malloc. This was caught by thread sanitizer.
PriyaAvhad
force-pushed
the
eng/PR-123808864
branch
from
0e3fe7b to
e173eda
Compare
|
@swift-ci test |
|
@swift-ci please smoke test |
|
@swift-ci test linux |
|
OK, if you're going to do that, then there's no need for my #827 changes for the 6.0 branch. Just don't forget to submit this revert to the 6.0 branch next. 😉 |
|
Will do. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caught by thread sanitizer.