Skip to content

🍒 [windows][lldb] implement system logging on Windows (#150213) #11315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 30, 2025
Merged

🍒 [windows][lldb] implement system logging on Windows (#150213) #11315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1c6cba
[windows][lldb] implement system logging on Windows (#150213)
charles-zablit Jul 31, 2025
d02ce92
[lldb][windows] remove duplicate implementation of UTF8ToUTF16 (#154424)
charles-zablit Aug 20, 2025
5070385
[lldb][windows] use OutputDebugStringA instead of c to log events (#1…
charles-zablit Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions lldb/source/Host/common/Host.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,27 @@ int __pthread_fchdir(int fildes);
using namespace lldb;
using namespace lldb_private;

#if !defined(__APPLE__)
// The system log is currently only meaningful on Darwin, where this means
// os_log. The meaning of a "system log" isn't as clear on other platforms, and
// therefore we don't providate a default implementation. Vendors are free to
// to implement this function if they have a use for it.
void Host::SystemLog(Severity severity, llvm::StringRef message) {}
#if !defined(__APPLE__) && !defined(_WIN32)
#include <syslog.h>
void Host::SystemLog(Severity severity, llvm::StringRef message) {
static llvm::once_flag g_openlog_once;
llvm::call_once(g_openlog_once, [] {
openlog("lldb", LOG_CONS | LOG_PID | LOG_NDELAY, LOG_USER);
});
int level = LOG_DEBUG;
switch (severity) {
case lldb::eSeverityInfo:
level = LOG_INFO;
break;
case lldb::eSeverityWarning:
level = LOG_WARNING;
break;
case lldb::eSeverityError:
level = LOG_ERR;
break;
}
syslog(level, "%s", message.data());
}
#endif

#if !defined(__APPLE__) && !defined(_WIN32)
Expand Down
29 changes: 29 additions & 0 deletions lldb/source/Host/windows/Host.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#include "lldb/Utility/StreamString.h"
#include "lldb/Utility/StructuredData.h"

#include "llvm/ADT/StringRef.h"
#include "llvm/Support/ConvertUTF.h"

// Windows includes
Expand All @@ -30,6 +31,8 @@
using namespace lldb;
using namespace lldb_private;

using llvm::sys::windows::UTF8ToUTF16;

static bool GetTripleForProcess(const FileSpec &executable,
llvm::Triple &triple) {
// Open the PE File as a binary file, and parse just enough information to
Expand Down Expand Up @@ -302,3 +305,29 @@ Environment Host::GetEnvironment() {
}
return env;
}

void Host::SystemLog(Severity severity, llvm::StringRef message) {
if (message.empty())
return;

std::string log_msg;
llvm::raw_string_ostream stream(log_msg);

switch (severity) {
case lldb::eSeverityWarning:
stream << "[Warning] ";
break;
case lldb::eSeverityError:
stream << "[Error] ";
break;
case lldb::eSeverityInfo:
default:
stream << "[Info] ";
break;
}

stream << message;
stream.flush();

OutputDebugStringA(log_msg.c_str());
}