Skip to content

Conversation

jmini
Copy link
Contributor

@jmini jmini commented Mar 15, 2018

Fix generated code: example EnumTest.java Line 59 on master branch

IS:

@XmlEnumValue(1) NUMBER_1(Integer.valueOf(1))

SHOULD BE:

@XmlEnumValue("1") NUMBER_1(Integer.valueOf(1))

This pull request migrates following:

  • {{#isInteger}} ... {{/isInteger}}
  • {{#isLong}} ... {{/isLong}}
  • {{#isDouble}} ... {{/isDouble}}
  • {{#isFloat}} ... {{/isFloat}}

Inside {{#enumVars}}..{{/enumVars}}

@jmini
Copy link
Contributor Author

jmini commented Mar 15, 2018

The explanation why {{#isInteger}} ... {{/isInteger}} is migrated to {{#is ../../this 'integer'}}..{{/is}} inside {{#enumVars}}..{{/enumVars}} can be usefull for other migration cases.

I have documented it in the wiki, in this new section: Evaluate a path against its parent context

@webron webron requested a review from HugoMario March 15, 2018 16:09
@jmini
Copy link
Contributor Author

jmini commented Mar 15, 2018

After #38 and #36 this is the the last change in order to be able to generate the JaxRS sample of the swagger-codegen repository. (JaxRS generators were introduced with #29).


When this pull request is merged, I will update the scripts for the continous integration and thesample folder. Everything is prepared on patch-9 branch.

@HugoMario HugoMario merged commit b41639f into swagger-api:master Mar 16, 2018
@HugoMario
Copy link
Contributor

thanks @jmini !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants