Skip to content

fix: escape <textarea value={...}> attribute properly #8434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 30, 2023
Merged

fix: escape <textarea value={...}> attribute properly #8434

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac10659
fix escape
baseballyama Mar 30, 2023
aadda27
now handle only textarea
baseballyama Mar 30, 2023
1ed69fa
refactor
baseballyama Mar 30, 2023
de081e3
remove empty line
baseballyama Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/runtime/internal/ssr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export function merge_ssr_styles(style_attribute, style_directive) {
return style_object;
}

const ATTR_REGEX = /[&"]/g;
const ATTR_REGEX = /[&"<]/g;
const CONTENT_REGEX = /[&<]/g;

/**
Expand Down
4 changes: 4 additions & 0 deletions test/runtime/samples/attribute-escape/_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
export default {
html: '<textarea></textarea>',
ssrHtml: '<textarea>test\'"&gt;&lt;/textarea&gt;&lt;script&gt;alert(\'BIM\');&lt;/script&gt;</textarea>'
};
1 change: 1 addition & 0 deletions test/runtime/samples/attribute-escape/main.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<textarea value={`test'"></textarea><script>alert('BIM');</script>`} />