Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/loud-numbers-flow.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"svelte": patch
---

fix: restore value after attribute removal during hydration
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,12 @@ import * as w from '../../warnings.js';
*/
export function remove_input_attr_defaults(dom) {
if (hydrating) {
// using getAttribute instead of dome.value allow us to have
// null instead of "on" if the user didn't set a value
const value = dom.getAttribute('value');
set_attribute(dom, 'value', null);
set_attribute(dom, 'checked', null);
if (value) dom.value = value;
}
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import { test } from '../../assert';

export default test({
html: `<input type="checkbox" name="lang" value="keep" />`,
ssrHtml: `<input type="checkbox" name="lang" value="keep" checked />`,
test({ window, assert, target, mod }) {
const input = target.querySelector('input');
assert.equal(input?.checked, true);
}
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<script>
let to_check = $state("keep")
</script>

<input type="checkbox" name="lang" value="keep" checked={to_check === "keep"} />