Skip to content

PR: Library: Slider - Introduce an option to render value and text in custom labels #10451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

PR: Library: Slider - Introduce an option to render value and text in custom labels #10451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fac44d
Slider - Introduce an option to render value and text in custom label…
dmitry-kurmanov Oct 3, 2025
8874e14
Merge branch 'master' into feature/10399-slider-show-value-in-custom-…
dmitry-kurmanov Oct 3, 2025
1e75f21
Slider - Introduce an option to render value and text in custom label…
dmitry-kurmanov Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/survey-core/src/question_slider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ export class SliderLabelItemValue extends ItemValue {
}
return this.value || 0;
}
public get showValue(): boolean {
return this.getPropertyValue("showValue", false);
}
public set showValue(val: boolean) {
this.setPropertyValue("showValue", val);
}
}

/**
Expand Down Expand Up @@ -902,7 +908,8 @@ Serializer.addClass(
[
{ name: "!value:number" },
{ name: "visibleIf", visible: false },
{ name: "enableIf", visible: false }
{ name: "enableIf", visible: false },
{ name: "showValue:boolean", locationInTable: "detail", default: false }
],
(value: any) => new SliderLabelItemValue(value),
"itemvalue"
Expand Down
5 changes: 5 additions & 0 deletions packages/survey-react-ui/src/components/slider/slider-label-item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,14 @@ export class SliderLabelItem extends SurveyElementBase<any, any> {
protected renderElement(): React.JSX.Element {
const { cssClasses, handleLabelPointerUp, getLabelCss, getPercent } = this.question;
const { value, locText } = this.item;
let labelValue = null;
if (this.item.showValue) {
labelValue = <div>{this.item.value}</div>;
}
return <div key={this.item.id} className={getLabelCss(locText)}
style={{ left: getPercent(value) + "%" }} onPointerUp={ (e)=>{ handleLabelPointerUp(e.nativeEvent, value); } }>
<div className={cssClasses.labelTick}></div>
{labelValue}
<div className={cssClasses.labelText}>
{this.renderLocString(locText)}
</div>
Expand Down