Skip to content

multi-container-machines: fix container -> name in depends_on #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

multi-container-machines: fix container -> name in depends_on #2136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions machines/guides-examples/multi-container-machines.html.markerb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

When creating a Machine via the API, you can specify a `containers` array, each containing a [`ContainerConfig`](https://docs.machines.dev/#model/flycontainerconfig). Each container can have its own image, environment variables, health checks, startup commands, attached files, and dependencies.

Flyd (our [in-house orchestrator](https://fly.io/blog/carving-the-scheduler-out-of-our-orchestrator/)), handles pulling images and making them accessible to Pilot, the init system responsible for running the containers and managing their lifecycle. Pilot builds a dependency graph using container startup conditions and runs containers accordingly.

Check failure on line 26 in machines/guides-examples/multi-container-machines.html.markerb

View workflow job for this annotation

GitHub Actions / Vale linter 

[vale] reported by reviewdog 🐶
[Vale.Terms] Use 'flyd' instead of 'Flyd'.

Raw Output:
{"message": "[Vale.Terms] Use 'flyd' instead of 'Flyd'.", "location": {"path": "machines/guides-examples/multi-container-machines.html.markerb", "range": {"start": {"line": 26, "column": 1}}}, "severity": "ERROR"}

## Example Configuration

Expand Down Expand Up @@ -66,7 +66,7 @@
},
"depends_on": [
{
"container": "my-app",
"name": "my-app",
"condition": "healthy"
}
]
Expand All @@ -84,7 +84,7 @@
```json
"depends_on": [
{
"container": "sidecar1",
"name": "sidecar1",
"condition": "healthy"
}
]
Expand Down Expand Up @@ -182,7 +182,7 @@

Starting with `flyctl v0.3.147`, you can run multiple containers using `fly deploy`. This example demonstrates using a nginx container as a rate limiter and a custom app container.

#### 1. Create cli-config.json

Check failure on line 185 in machines/guides-examples/multi-container-machines.html.markerb

View workflow job for this annotation

GitHub Actions / Vale linter 

[vale] reported by reviewdog 🐶
[Vale.Terms] Use 'JSON' instead of 'json'.

Raw Output:
{"message": "[Vale.Terms] Use 'JSON' instead of 'json'.", "location": {"path": "machines/guides-examples/multi-container-machines.html.markerb", "range": {"start": {"line": 185, "column": 27}}}, "severity": "ERROR"}

```json
{
Expand All @@ -199,7 +199,7 @@
],
"depends_on": [
{
"container": "echo",
"name": "echo",
"condition": "healthy"
}
]
Expand Down
Loading