Implement Add Feature #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add is similar to 'install' except it generates an output file which a user can manually execute later. Code shared between `add` and `install` has been moved to `utils.rs` and `models.rs`
|
@Proziam is attempting to deploy a commit to the Supabase Team on Vercel. A member of the Team first needs to authorize it. |
imor
reviewed
Jan 11, 2025
imor
reviewed
Jan 11, 2025
imor
reviewed
Jan 11, 2025
imor
reviewed
Jan 11, 2025
Also added schema to the Payload model to be parsed from .control files, if present.
|
This looks good, thanks @Proziam for the PR. |
imor
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add is similar to
installexcept it generates an output file which a user can manually execute later.Code shared between
addandinstallhas been moved toutils.rsandmodels.rsTesting
This was tested on a demo db with the index_advisor extension and seemed to work as expected.