Allow uploading in-memory files #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
commented
Oct 23, 2017
| @classmethod | ||
| def api_base(cls): | ||
| return upload_api_base | ||
| return stripe.upload_api_base |
There was a problem hiding this comment.
Opportunistic fix to ensure that the current value of upload_api_base is used (before, the value was only read once when the library is loaded).
|
Oh man, the conversation we had about this in #227 was like 10x longer than the fix turned out to be! Thanks for being the one to take action here Olivier :) And thanks for adding the new test too — really helpful in helping to understand that this does the right thing. LGTM. |
|
Released as 1.70.0. |
|
Thanks @ob-stripe ! |
This was referenced Oct 26, 2017
This was referenced Nov 2, 2017
This was referenced Nov 29, 2017
This was referenced Dec 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries @praboud-stripe
Fixes #227.
I spent some time investigating this and I agree with @praboud-stripe's analysis in #227. Rack returns multipart blocks with no filenames directly as
Strings rather than asHashes -- they explicitly test for this behavior (cf. here).Fixing the backend to handle either a string or a hash might be possible, but sending a dummy filename in the client libraries is definitely the path of least resistance. We actually already do this in stripe-node (cf. here).