⚠️ Unify resource and service method parameters into one class #1596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helenye-stripe
requested review from
mbroshi-stripe
and removed request for
a team
xavdid-stripe
approved these changes
Sep 26, 2025
| @@ -1,43 +1,25 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # File generated from our OpenAPI spec | |||
| from stripe._account_capability_list_params import AccountCapabilityListParams | |||
There was a problem hiding this comment.
these should all probably go in an if TYPE_CHECKING block. Won't need changes to the main body of the service, since the types are already in a string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Decrease the size of the library for unnecessary duplicated types
What?
Moves all params (service and resource) to the top level and are shared.
Generated changes only.
See Also
Changelog
_stripe._account.CreateParamsand_stripe._account_service.CreateParamshave moved to_stripe._account_create_params.AccountCreateParams