Skip to content

fix: paginate backwards if starting_after == None #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2025
Merged

fix: paginate backwards if starting_after == None #1563

merged 2 commits into from
Sep 4, 2025

Conversation

ryancausey
Copy link
Contributor

Why?

This fixes the case where starting_after is present in _retrieve_params but is None so that the auto_paging_iter correctly paginates backwards.

What?

  • This fixes the case where starting_after is present in _retrieve_params but is None so that the auto_paging_iter correctly paginates backwards.
  • adds tests to confirm this behavior

See Also

closes #1562

@ryancausey
fix: paginate backwards if starting_after == None
27fc74d 
This fixes the case where `starting_after` is present in
`_retrieve_params` but is `None` so that the `auto_paging_iter`
correctly paginates backwards.

closes stripe#1562
@ryancausey ryancausey requested a review from a team as a code owner August 31, 2025 19:32
@ryancausey ryancausey requested review from jar-stripe and removed request for a team August 31, 2025 19:32
@cla-assistant CLA Assistant
Copy link

cla-assistant bot commented Aug 31, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mbroshi-stripe mbroshi-stripe mentioned this pull request Sep 2, 2025
Closed
@mbroshi-stripe mbroshi-stripe enabled auto-merge (squash) September 2, 2025 18:57
mbroshi-stripe
mbroshi-stripe approved these changes Sep 2, 2025
View reviewed changes
Copy link
Contributor

@mbroshi-stripe mbroshi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good! Thanks for adding tests too!

@mbroshi-stripe
Copy link
Contributor

@ryancausey Looks great! Can you run just format locally and commit? There are lint errors

@mbroshi-stripe mbroshi-stripe merged commit 0caf855 into stripe:master Sep 4, 2025
14 checks passed
@ryancausey
Copy link
Contributor Author

Thanks for formatting and merging!

prathmesh-stripe pushed a commit that referenced this pull request Sep 15, 2025
@ryancausey @prathmesh-stripe
fix: paginate backwards if starting_after == None (#1563)
082975b 
This fixes the case where `starting_after` is present in
`_retrieve_params` but is `None` so that the `auto_paging_iter`
correctly paginates backwards.

closes #1562
helenye-stripe pushed a commit that referenced this pull request Sep 22, 2025
@xavdid-stripe @stripe-openapi
@ramya-stripe @prathmesh-stripe @mbroshi-stripe @claude @ryancausey
Xavdid/merge python private preview (#1574)
f977082 
* Update generated code for v1868 and 2025-07-30.basil (#1541)

Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>

* Bump version to 12.4.0

* Introduce V1 namespaces in StripeClient (#1549)

* Introduced V1 namespaces

* Updated migration guide link

* Import available http libraries more efficiently (#1553)

* replace import stragety, fix some tests

[skip ci]

* wip fixing tests

[skip ci]

* [claude] fix tests

* formatting

* test cleanup

* tests are fast

* final cleanup

* remove comment

* remove accidential files

* tweak import logic

* Update generated code for v1932 and 2025-08-27.basil (#1544)

Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>
Co-authored-by: Ramya Rao <[email protected]>

* Add section on private preview SDKs in readme (#1554)

* Bump version to 12.5.0

* Add private-preview branch to CI workflow triggers

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* fix: paginate backwards if `starting_after == None` (#1563)

This fixes the case where `starting_after` is present in
`_retrieve_params` but is `None` so that the `auto_paging_iter`
correctly paginates backwards.

closes #1562

* Bump version to 12.5.1

* add support for v2 deleted objects (#1543)

* add support for v2 deleted objects

* revert event destination return type

* ⚠️ Build SDK w/ V2 OpenAPI spec (#1565)

* generate w/ v2 openapi spec

* gen again

* gen

* Updated stripeclient snippets in Readme.md (#1528)

* Don't use mutable default arguments (#1570)

* generate default assignments

* add mutable args linter and fix errors

* type generated args more accurately

* only initialize optional params when needed

* generate private-preview

---------

Co-authored-by: stripe-openapi[bot] <105521251+stripe-openapi[bot]@users.noreply.github.com>
Co-authored-by: Ramya Rao <[email protected]>
Co-authored-by: prathmesh-stripe <[email protected]>
Co-authored-by: Ramya Rao <[email protected]>
Co-authored-by: Michael Broshi <[email protected]>
Co-authored-by: Claude <[email protected]>
Co-authored-by: Ryan Causey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbroshi-stripe mbroshi-stripe mbroshi-stripe approved these changes

@jar-stripe jar-stripe Awaiting requested review from jar-stripe jar-stripe is a code owner automatically assigned from stripe/api-library-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auto_paging_iter does not paginate backwards if starting_after is None
3 participants
@ryancausey @mbroshi-stripe @prathmesh-stripe