fix: make micros compatible with ISR #1702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is kind of revert commit 15dc04b. Note: `delayMicroseconds()` does not rely anymore on `micros()` so accuracy is less important. Fixes stm32duino#1680 Signed-off-by: Frederic Pillon <[email protected]>
|
Hi @matthijskooijman |
|
I'm a bit late to the party, have been a bit busy with some other work ;-) Code looks exactly right to me. I'll see if I can find a little bit more time to also test against my original testcase, but I'm confident this will work correctly. Thanks! |
|
I've tested your sketch and was not able to reproduce ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is kind of revert commit 15dc04b.
Note:
delayMicroseconds()does not rely anymore onmicros()so accuracy is less important.Fixes #1680
/cc @matthijskooijman