-
Notifications
You must be signed in to change notification settings - Fork 218
Move Core Dockerfile into repo and reduce size #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can caching help here? Another idea is to explore if we can use the SDF internal docker registry to download the image instead of building it. Core's Jenkins job creates packages and puts them in |
This repo already heavily use caching. This repo builds from source so we can produce quickstart images of any software components, which is why it doesn't download packages from other sources prebuilt. |
For some reason this PR auto merged even though the build was failing. Investigating. |
What
Move the Core Dockerfile used to build core into the repo, and reduce the image artifact by making its final step minimal.
Why
Reduce the size of intermediary images that are stored and passed around between jobs. It reduces the time copying images between jobs, and reduces the total size of artifacts stored in GitHub actions.