Skip to content

Conversation

leighmcculloch
Copy link
Member

What

Move the Core Dockerfile used to build core into the repo, and reduce the image artifact by making its final step minimal.

Why

Reduce the size of intermediary images that are stored and passed around between jobs. It reduces the time copying images between jobs, and reduces the total size of artifacts stored in GitHub actions.

@leighmcculloch leighmcculloch marked this pull request as ready for review September 30, 2025 07:53
@leighmcculloch leighmcculloch enabled auto-merge (squash) September 30, 2025 09:48
@anupsdf
Copy link
Contributor

anupsdf commented Sep 30, 2025

Reduce the size of intermediary images that are stored and passed around between jobs. It reduces the time copying images between jobs, and reduces the total size of artifacts stored in GitHub actions.

Can caching help here? Another idea is to explore if we can use the SDF internal docker registry to download the image instead of building it. Core's Jenkins job creates packages and puts them in docker-registry.services.stellar-ops.com/dev/stellar-core:23.0.2-2735.f5fba53aa.jammy...

@leighmcculloch
Copy link
Member Author

Can caching help here? Another idea is to explore if we can use the SDF internal docker registry to download the image instead of building it. Core's Jenkins job creates packages and puts them in docker-registry.services.stellar-ops.com/dev/stellar-core:23.0.2-2735.f5fba53aa.jammy...

This repo already heavily use caching. This repo builds from source so we can produce quickstart images of any software components, which is why it doesn't download packages from other sources prebuilt.

@leighmcculloch leighmcculloch removed the request for review from graydon September 30, 2025 20:38
@leighmcculloch leighmcculloch merged commit fb6d425 into main Sep 30, 2025
278 of 314 checks passed
@leighmcculloch leighmcculloch deleted the coreimg branch September 30, 2025 22:41
@github-project-automation github-project-automation bot moved this from Backlog (Not Ready) to Done in DevX Sep 30, 2025
@leighmcculloch
Copy link
Member Author

For some reason this PR auto merged even though the build was failing. Investigating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants