Skip to content

Conversation

navyansh007
Copy link
Contributor

Resolves #8205 .

Description

What is the purpose of this pull request?

This pull request implements the half-normal statistical distribution, which is under stats/base/dists

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
…mplementation

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Oct 6, 2025
@Planeshifter Planeshifter self-requested a review October 7, 2025 16:44
@kgryte
Copy link
Member

kgryte commented Oct 14, 2025

@navyansh007 Thanks for working on this. I am going to mark this PR as "draft", as the various packages only add the implementations, but not all the associated documentation (README, TypeScript declarations, REPL text, etc), tests, benchmarks, and examples. You'll need to add those before this PR can move forward. It may be easier if you split the various sub-packages into separate PRs. Otherwise, this PR will end up with many files and review will likely be slower.

@kgryte kgryte marked this pull request as draft October 14, 2025 13:43
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Oct 14, 2025
@navyansh007
Copy link
Contributor Author

Hey @kgryte,
Thank you for getting back to me. So here is what I understood. WIll it be a good idea to raise multiple PRs that implement a small part of the halfnormal distribution package namespace (for example, I raise a PR that solely implements cdf subpackage for halfnormal)?

@kgryte
Copy link
Member

kgryte commented Oct 15, 2025

I raise a PR that solely implements cdf subpackage for halfnormal

Correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add support for half-normal distribution @stdlib/stats/base/dists/halfnormal

3 participants