Skip to content

Conversation

ataranto
Copy link

closed pr 14

@sta
Copy link
Owner

sta commented Mar 13, 2013

i'm using it to set a "Cookie" header for authentication, but obviously you could use it to include any arbitrary headers in every request or every response

I think adding the feature to set cookie (e.g. SetCookie method) is more safe and your fix (adding Headers property) can do too many.

@ataranto
Copy link
Author

ok. i was also thinking of adding a cookie parameter to the WebSocket constructor. Which approach would you prefer?

@sta
Copy link
Owner

sta commented Mar 18, 2013

I plan to add the followings.

public IEnumerable<Cookie> Cookies { get; }

public void SetCookie (Cookie cookie)

or

public CookieCollection Cookies { get; }

I don't plan to add a new constructor with a cookie parameter.

@sta
Copy link
Owner

sta commented Mar 18, 2013

BTW, what kind of the WebSocket server do you use? How does the server authenticate using cookies?

sta added a commit that referenced this pull request Apr 6, 2013
@ataranto
Copy link
Author

ataranto commented Apr 6, 2013

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants