-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PR: Increase default max console buffer and warn if it's big (IPython console) #25028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ccordoba12
merged 3 commits into
spyder-ide:master
from
CAM-Gerlach:console-confpage-increase-buffer
Sep 25, 2025
Merged
PR: Increase default max console buffer and warn if it's big (IPython console) #25028
ccordoba12
merged 3 commits into
spyder-ide:master
from
CAM-Gerlach:console-confpage-increase-buffer
Sep 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Sep 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CAM-Gerlach for your work on this!
CAM-Gerlach
commented
Sep 24, 2025
CAM-Gerlach
commented
Sep 24, 2025
508e8ed
to
0416f04
Compare
0416f04
to
2b3c489
Compare
Co-authored-by: Carlos Cordoba <[email protected]>
2b3c489
to
800b726
Compare
ccordoba12
approved these changes
Sep 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @CAM-Gerlach!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Followup to #25010
Related to #19091
The current default value of the Console buffer size (scrollback length) under
Preferences > IPython Console > Interface
is very low at only 500 lines, barely a handful of screenfulls of text. Given in 2025 machines can easily handle, and many users expect, far more, and the default setting results in permanent data loss, it seems reasonable to increase it to at least 5000.Meanwhile, the maximum value was apparently set to only 5000 due to #19091, where a user reported that Spyder was very slugging when the Console buffer size (scrollback length) was set to 50k lines. @ccordoba12 postulated that this could occur with a buffer size >10k lines, and although the maximum was set to half of that still.
However, the setting still allows (and even mentions in the tooltip) a value of
-1
, which sets the buffer size to unlimited. Given a user desiring a buffer size larger than 5k would have no choice but to set that, which is strictly worse for Spyder's performance than any fixed buffer size, it seems only reasonable to allow a much larger maximum (or none at all); I've set it to 100k for now.Yet, we should warn users about this more visibility than just a mention in the tooltip. As such, I've implemented a callback on applying a change to this setting that pops up a warning dialog if either >10k lines is set for the buffer, or an unlimited buffer (
-1
) is set.Additionally, I've cleaned up a handful of remaining formatting issues not caught in #25010
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: CAM-Gerlach