Skip to content

PR: Prevent to add site-packages directories placed inside AppData ones to the Pythonpath manager #23668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 10, 2025
Merged

PR: Prevent to add site-packages directories placed inside AppData ones to the Pythonpath manager #23668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
58bfd3c
add regex to validate appData
jsbautista Feb 6, 2025
174f092
fix pattern_string
jsbautista Feb 7, 2025
01624f2
fix pattern_string
jsbautista Feb 7, 2025
bf3e7da
Merge branch 'master' into checkPathPFM
jsbautista Feb 10, 2025
9bdd9b3
fix pattern_string
jsbautista Feb 10, 2025
75e2f84
Merge branch 'checkPathPFM' of https://github.com/jsbautista/spyder i…
jsbautista Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions spyder/plugins/pythonpath/tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ def test_check_path(tmp_path):
assert not check_path('lib\\dist-packages')
assert not check_path('Lib/site-packages')
assert not check_path('Anaconda3/pkgs')
assert not check_path("C:\\Users\\user\\AppData\\Roaming\\Python\\Scripts")
else:
# One digit Python versions
assert not check_path('lib/python3.9/site-packages')
Expand Down
4 changes: 3 additions & 1 deletion spyder/plugins/pythonpath/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@ def check_path(path):
"""
pattern_string = r'(ana|mini|micro)(conda|mamba|forge)\d*(/base)*/pkgs'
if os.name == 'nt':
path_appdata = os.getenv("APPDATA").replace('\\', '/')
pattern_string = (
f'.*({pattern_string}'
r'|(l|L)ib/(site|dist)-packages).*'
r'|(l|L)ib/(site|dist)-packages.*'
f'|(AppData|{path_appdata})/Roaming/Python).*'
)
else:
pattern_string = (
Expand Down
Loading