Introduce getContentAsString() in ContentCachingRequestWrapper
#30709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a method, getContentAsString, to ContentCachingRequestWrapper. Having a method directly on ContentCachingRequestWrapper allows delegating to the toString(Charset) method of ByteArrayOutputStream, avoiding an extra copy that calling getContentAsByteArray and then converting to a String would.
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
added
in: web
snicoll
pushed a commit
that referenced
this pull request
Aug 22, 2023
This commits adds a getContentAsString method to ContentCachingRequestWrapper that uses the configured charset without copying the underlying byte array. See gh-30709
snicoll
added a commit
that referenced
this pull request
Aug 22, 2023
|
Thanks again @kilink |
sbrannen
changed the title
getContentAsString() in ContentCachingRequestWrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a method,
getContentAsString, toContentCachingRequestWrapper. Having a method directly onContentCachingRequestWrapperallows delegating to thetoString(Charset)method ofByteArrayOutputStream, avoiding an extra copy that callinggetContentAsByteArrayand then converting to aStringwould.In practice I've seen a lot of usages of
ContentCachingRequestWrapperwheregetContentAsByteArrayis called and the returned bytes are immediately decoded to aString; this method would allow a user to avoid the overhead of the extra copy that incurs.