Skip to content

StreamMessageListenerContainer should wait until listeners finish processing within timeout during shutdown #2563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

StreamMessageListenerContainer should wait until listeners finish processing within timeout during shutdown #2563

wants to merge 1 commit into from

Conversation

aooohan
Copy link

@aooohan aooohan commented Apr 20, 2023 •
edited
Loading

Fix issue: #2261

Set a new option shutdownTimeout for container option. The container will wait listener with shutdownTimeout time to finish processing.

If any improvement can do, feel free to tell me.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@aooohan aooohan mentioned this pull request Apr 20, 2023
Open
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 20, 2023
@christophstrobl christophstrobl added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 8, 2023
mp911de
mp911de reviewed Oct 17, 2023
View reviewed changes
src/main/java/org/springframework/data/redis/stream/DefaultStreamMessageListenerContainer.java

subscriptions.forEach(Cancelable::cancel);

subscriptions.stream()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running a busy-spin cannot be interrupted. Also, keeping common ForkJoin pool threads busy asks for trouble.

Instead, our Tasks should report a completion future that we can listen to.

@mp911de mp911de added the status: pending-design-work Needs design work before any code can be developed label Oct 17, 2023
@jxblum jxblum force-pushed the main branch 2 times, most recently from d43adc9 to a71f042 Compare October 18, 2023 03:07
@JiHongKim98 JiHongKim98 mentioned this pull request Nov 11, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mp911de mp911de mp911de left review comments

+1 more reviewer

@vuhp vuhp vuhp left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mp911de mp911de

Labels

status: pending-design-work Needs design work before any code can be developed type: enhancement A general enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aooohan @mp911de @vuhp @christophstrobl @spring-projects-issues