Add native image support for Log4J integration #46410
Closed
+163
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
changed the title
snicoll
added
type: enhancement
|
Blocked on #46334. |
mhalbritter
added
the
status: blocked
snicoll
removed
the
status: blocked
snicoll
requested changes
Sep 29, 2025
There was a problem hiding this comment.
@ppkarwasz thanks for the PR. can you please review the comments and rebase now that we have upgraded to 2.25.x
Also, wondering about Jackson as we've moved to Jackson 3 by default and users would have then to bring Jackson 2 to be able to parse a YAML configuration?
core/spring-boot/src/main/java/org/springframework/boot/logging/log4j2/Log4J2LoggingSystem.java
Outdated
Show resolved
Hide resolved
core/spring-boot/src/main/java/org/springframework/boot/logging/log4j2/Log4J2LoggingSystem.java
Outdated
Show resolved
Hide resolved
core/spring-boot/src/main/java/org/springframework/boot/logging/log4j2/Log4J2RuntimeHints.java
Outdated
Show resolved
Hide resolved
snicoll
added
the
status: waiting-for-feedback
Unfortunately the rebase isn't done properly. If I try to squash all those commits into one, I am getting back to merge conflicts. Can you please sort that out? |
This change introduces AOT runtime hints for Log4j Core 2 to support its integration with Spring Boot native images. Starting with version `2.25.0`, Log4j Core 2 includes built-in GraalVM reachability metadata, allowing native image generation without requiring additional manual configuration. This contribution complements that by adding Spring Boot–specific metadata: * Registers default Spring Boot configuration files. * Registers classes referenced via `ClassUtils.isPresent(...)` checks. Fixes spring-projects#42273. > [!NOTE] > This change should be reviewed in conjunction with spring-projects#46334, which configures Log4j Core’s `GraalVmProcessor` to generate reachability metadata for Spring Boot’s custom Log4j plugins. Signed-off-by: Piotr P. Karwasz <[email protected]>
ppkarwasz
force-pushed
the
fix/42273_spring-log4j-runtime-hints
branch
from
b4af397 to
06fc66c
Compare
|
I usually |
spring-projects-issues
added
status: feedback-provided
Signed-off-by: Piotr P. Karwasz <[email protected]>
snicoll
pushed a commit
that referenced
this pull request
Oct 8, 2025
This change introduces runtime hints for Log4j Core 2 to support its integration with Spring Boot native images. Starting with Log4j 2.25.x, Log4j includes built-in GraalVM reachability metadata, allowing native image generation without requiring additional manual configuration. This contribution complements that by adding Spring Boot–specific metadata: * Registers default Spring Boot configuration files. * Registers classes referenced via `ClassUtils.isPresent(...)` checks. See gh-46410 Signed-off-by: Piotr P. Karwasz <[email protected]>
snicoll
added a commit
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces AOT runtime hints for Log4j Core 2 to support its integration with Spring Boot native images.
Starting with version
2.25.0, Log4j Core 2 includes built-in GraalVM reachability metadata, allowing native image generation without requiring additional manual configuration.This contribution complements that by adding Spring Boot–specific metadata:
ClassUtils.isPresent(...)checks.Fixes #42273.
Note
This change should be reviewed in conjunction with #46334, which configures Log4j Core’s
GraalVmProcessorto generate reachability metadata for Spring Boot’s custom Log4j plugins.