This repository was archived by the owner on Oct 20, 2021. It is now read-only.
Add premerge/release-qa buildkite pipelines #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 26, 2019 18:37
Signed-off-by: Paul Balaji <[email protected]>
Signed-off-by: Paul Balaji <[email protected]>
jamiebrynes7
approved these changes
Feb 28, 2019
|
|
||
| uploadAssembly "${ASSEMBLY_PREFIX}" "${PROJECT_NAME}" | ||
|
|
||
| markStartOfBlock "Launching deployments" |
There was a problem hiding this comment.
Given this is only running on BK we can drop these (as they are TC specific markers)
There was a problem hiding this comment.
Will need to go through all our ci scripts properly when we fully migrate off TC 👍
| @@ -1,22 +0,0 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Probably want to remove the Release QA pipeline on TC since we've removed this. Or restore it and make a note to remove it when we kill TC
There was a problem hiding this comment.
Removing Release QA pipeline from TC as it looks like it's not actually being run
jessicafalk
approved these changes
Feb 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
very very similar to the changes here: spatialos/gdk-for-unity-fps-starter-project#115
Description
build.shthat's been moved togdk-for-unity-shared-cici/upload-launch.shtoci/launch.shTests
ran through buildkite and TC, looks green to me
Documentation
n/a
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.