fix: use accountId parameter for user lookups in Jira Cloud OAuth mode #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix is_cloud property to correctly identify Multi-Cloud OAuth as Cloud instance - OAuth with cloud_id now always returns True for is_cloud check - This ensures user lookups use accountId parameter instead of username - Also fixes Confluence v2 adapter issues in Multi-Cloud OAuth mode - Add test coverage for OAuth cloud detection Reported-by: Muhammad Ali Reported-by: Ian Github-Issue: #560 Github-Issue: #580
2 tasks
sooperset
added a commit
that referenced
this pull request
Jun 30, 2025
When using Multi-Cloud OAuth with BYOT (Bring Your Own Token) flow, Confluence's is_cloud property incorrectly returned false because it only checked the URL pattern. In Multi-Cloud setups, the URL may be None or empty as requests use api.atlassian.com with a cloud_id. This fix ensures that OAuth configurations with a cloud_id are always treated as Cloud instances, enabling proper v2 API adapter activation and preventing authentication failures. The implementation matches the fix already applied to Jira in PR #581. Reported-by: Ian Github-Issue: #580
7 tasks
sooperset
added a commit
that referenced
this pull request
Jun 30, 2025
* fix: detect Confluence Cloud instances in Multi-Cloud OAuth mode When using Multi-Cloud OAuth with BYOT (Bring Your Own Token) flow, Confluence's is_cloud property incorrectly returned false because it only checked the URL pattern. In Multi-Cloud setups, the URL may be None or empty as requests use api.atlassian.com with a cloud_id. This fix ensures that OAuth configurations with a cloud_id are always treated as Cloud instances, enabling proper v2 API adapter activation and preventing authentication failures. The implementation matches the fix already applied to Jira in PR #581. Reported-by: Ian Github-Issue: #580 * chore: revert uv.lock changes from previous commit Reverts unintended uv.lock changes that were included in the fix for Confluence Cloud detection in Multi-Cloud OAuth mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where
jira_get_user_profilefails in Multi-Cloud OAuth mode when called with an email address. The API was incorrectly using theusernameparameter instead ofaccountIdfor Jira Cloud instances.Fixes: #560, #580
Changes
JiraConfig.is_cloudproperty to correctly identify Multi-Cloud OAuth as a Cloud instancecloud_idnow always returnTrueforis_cloudcheckTesting
is_cloudreturnsTruefor OAuth with cloud_idChecklist
Additional Context
In Multi-Cloud OAuth mode, the
JIRA_URLenvironment variable may be None or empty, but the actual API URL used ishttps://api.atlassian.com/ex/jira/{cloud_id}which is definitely a Cloud URL. The fix ensures that when OAuth is configured with a cloud_id, it's always treated as a Cloud instance, regardless of the configured URL.This resolves the issue where user lookups were failing with the error: "The 'accountId' query parameter needs to be provided" because the API was incorrectly using
usernameparameter for email-based lookups on Jira Cloud.