fix: eliminate circular reference in Confluence preprocessor #574
+91
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove circular reference between ConfluenceClient and ConfluencePreprocessor that was preventing proper garbage collection and causing memory leaks. The preprocessor no longer stores a reference to the client. Instead, the client is passed as a parameter to methods that need it for user lookups. This follows the same pattern used by JiraPreprocessor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a circular reference between
ConfluenceClientandConfluencePreprocessorthat was preventing proper garbage collection and causing memory leaks in long-running processes.The preprocessor was storing a reference to the client, which in turn held a reference to the preprocessor, creating a circular dependency that Python's garbage collector couldn't break.
Relevant issue: #532
Changes
confluence_clientparameter fromBasePreprocessor.__init__process_html_contentand related methods to accept client as parameterJiraPreprocessorpatternTesting
Checklist