Skip to content

Conversation

lilyinstarlight
Copy link
Contributor

@lilyinstarlight lilyinstarlight commented Sep 29, 2022

The code works by chance now in Qt 6 but there is no guarantee it will continue working without including the header. The relevant documentation pages (Qt 6, Qt 5) indicate the <QThread> header is required and currently the code fails to compile in main.cpp on my system because the QThread type is not fully qualified

@samaaron samaaron merged commit 77732f8 into sonic-pi-net:dev Sep 30, 2022
@samaaron
Copy link
Collaborator

Wonderful, thank-you so much!

@lilyinstarlight lilyinstarlight deleted the fix/qthread-include branch September 30, 2022 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants