[Content]: Clarify how `query` cache works

[klequis]

📚 Subject area/topic

/solid-router/reference/data-apis/query.mdx

📋 Page(s) affected (or suggested, for new content)

https://docs.solidjs.com/solid-router/reference/data-apis/query

📋 Description of content that is out-of-date or incorrect

I think this is an important point that is easy to overlook and has considerable implications a user's understanding of how the cach for query works. I suggest stating that there is one cache for for all queries near the top of the page.

"*Since the internal cache is shared by all the functions using query"

As a secondary note to that, it leaves me wondering if there is one cache for the module, the component or all components/modules.

🖥️ Reproduction in StackBlitz (if reporting incorrect content or code samples)

No response

[amirhhashemi]

Yes, I completely agree that this needs clarification. It's been on my radar for a while, but I already have a lot on my plate. So it will take a while to address it, unless a hero comes forward to help.

[klequis]

As it turns out, there is one cache for all queries in all routes.
If you have 2 or more queries with the same key the results/data for the first one executed will be returned for all of them.

As far as updating this doc page, there is already a large callout at the top of the page. I thought about adding it there but I know the preference is to keep callouts minimal.

Here are two ways of stating it.
option1: There is only one query cache for all querys in all routes. Therefore, each query in your application must have a unique key parameter.

option2: Each query must have its own unique key parameter or one query will return the cached result of the other..

[klequis]

I have a number of suggestions for this page but unfortunately little time to update it now. Actually I am typing too much and my fingers are sore :).

I'm happy to make a list of suggestions. I could put them here or open a new issue?

[amirhhashemi]

I could put them here or open a new issue?

@klequis Just put them here. Thank you.

[brenelz]

I see there was a pr changing this. Can we close this issue?

[amirhhashemi]

I see there was a pr changing this. Can we close this issue?

We’ll close this once that PR is merged into the main branch.