Skip to content

Conversation

atellwu
Copy link
Contributor

@atellwu atellwu commented Mar 2, 2020

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #.

If there is no issue then describe the changes introduced by this PR.

@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes size/M labels Mar 2, 2020
@codecov-io
Copy link

Codecov Report

Merging #93 into master will decrease coverage by 0.3%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #93      +/-   ##
============================================
- Coverage     62.75%   62.45%   -0.31%     
  Complexity       44       44              
============================================
  Files           429      429              
  Lines         15445    15461      +16     
  Branches       1488     1489       +1     
============================================
- Hits           9693     9656      -37     
- Misses         4734     4787      +53     
  Partials       1018     1018
Impacted Files Coverage Δ Complexity Δ
...ta/event/handler/DataServerChangeEventHandler.java 41.41% <0%> (-0.43%) 0 <0> (ø)
...ssion/scheduler/task/DataChangeFetchCloudTask.java 62.12% <100%> (+2.44%) 0 <0> (ø) ⬇️
...istry/server/session/registry/SessionRegistry.java 75.58% <100%> (+0.14%) 0 <0> (ø) ⬇️
...rver/session/node/service/DataNodeServiceImpl.java 60.55% <100%> (-6.49%) 0 <0> (ø)
...egistry/server/session/store/SessionInterests.java 79.51% <33.33%> (+2.77%) 0 <0> (ø) ⬇️
...ver/session/bootstrap/SessionServerConfigBean.java 50.93% <50%> (-0.72%) 0 <0> (ø)
.../bootstrap/MetaServerInitializerConfiguration.java 57.14% <0%> (-14.29%) 0% <0%> (ø)
...egistry/server/meta/store/SessionStoreService.java 56.59% <0%> (-9.35%) 0% <0%> (ø)
...istry/server/meta/registry/MetaServerRegistry.java 66.66% <0%> (-9.1%) 0% <0%> (ø)
...a/registry/task/scheduler/TimedSupervisorTask.java 65.51% <0%> (-6.9%) 0% <0%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6d1741...e7f971f. Read the comment docs.

@Synex-wh Synex-wh merged commit a3728fc into sofastack:master Mar 3, 2020
dzdx pushed a commit that referenced this pull request Dec 13, 2021
* fix npe in DataServerChangeEventHandler

* bugfix in cloud mode: If obtained datum from DataServer failed, should set sessionInterests version zero

* add dataNodeExchangeForFetchDatumTimeOut; add log for fetchChangDataProcess

* update ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants