Skip to content

Conversation

nocvalight
Copy link
Member

Motivation:

Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #<118>.

#118

@nocvalight nocvalight force-pushed the disconnect_delay_configurable branch from 717691d to 0d17d7d Compare September 2, 2020 09:30
@sofastack-bot sofastack-bot bot added size/S and removed size/L labels Sep 2, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #141 into master will decrease coverage by 0.38%.
The diff coverage is 20.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #141      +/-   ##
============================================
- Coverage     62.61%   62.22%   -0.39%     
  Complexity       44       44              
============================================
  Files           429      429              
  Lines         15502    15507       +5     
  Branches       1490     1490              
============================================
- Hits           9706     9649      -57     
- Misses         4783     4844      +61     
- Partials       1013     1014       +1     
Impacted Files Coverage Δ Complexity Δ
.../sessionserver/SessionServerConnectionFactory.java 57.62% <0.00%> (-1.00%) 0.00 <0.00> (ø)
...gistry/server/data/bootstrap/DataServerConfig.java 59.52% <25.00%> (-0.85%) 0.00 <0.00> (ø)
...r/session/scheduler/SessionThreadPoolExecutor.java 66.66% <0.00%> (-33.34%) 0.00% <0.00%> (ø%)
...try/jraft/handler/RaftServerConnectionHandler.java 40.00% <0.00%> (-20.00%) 0.00% <0.00%> (ø%)
...registry/remoting/bolt/ConnectionEventAdapter.java 51.72% <0.00%> (-17.25%) 0.00% <0.00%> (ø%)
...sofa/registry/server/data/change/SnapshotData.java 90.00% <0.00%> (-10.00%) 0.00% <0.00%> (ø%)
...egistry/server/meta/store/SessionStoreService.java 56.59% <0.00%> (-9.35%) 0.00% <0.00%> (ø%)
...istry/server/meta/registry/MetaServerRegistry.java 66.66% <0.00%> (-9.10%) 0.00% <0.00%> (ø%)
...ipay/sofa/registry/server/data/util/DelayItem.java 52.17% <0.00%> (-8.70%) 0.00% <0.00%> (ø%)
...y/sofa/registry/server/data/change/ChangeData.java 58.33% <0.00%> (-8.34%) 0.00% <0.00%> (ø%)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 505e36b...0d17d7d. Read the comment docs.

@nocvalight nocvalight requested a review from dzdx October 12, 2020 06:04
Copy link
Member

@dzdx dzdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nocvalight nocvalight requested a review from quhongwei October 12, 2020 07:16
@nocvalight nocvalight merged commit e5d1e19 into sofastack:master Oct 12, 2020
dzdx pushed a commit that referenced this pull request Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants