Skip to content

Conversation

nocvalight
Copy link
Member

Motivation:

since registry-data.log,registry-session.log,registry-exchange.log, cache-digest.log print too much, and currently log is split by day. The log file is too large and the server disk will be easily full up.

Result:

Fixes #<139>.

If there is no issue then describe the changes introduced by this PR.
#139

@codecov-commenter
Copy link

Codecov Report

Merging #140 into master will decrease coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #140      +/-   ##
============================================
- Coverage     62.49%   62.16%   -0.33%     
  Complexity       44       44              
============================================
  Files           429      429              
  Lines         15502    15500       -2     
  Branches       1490     1490              
============================================
- Hits           9688     9636      -52     
- Misses         4802     4854      +52     
+ Partials       1012     1010       -2     
Impacted Files Coverage Δ Complexity Δ
...server/data/change/event/DataChangeEventQueue.java 89.02% <ø> (-0.14%) 0.00 <0.00> (ø)
...ssion/scheduler/task/DataChangeFetchCloudTask.java 62.12% <ø> (ø) 0.00 <0.00> (ø)
...sofa/registry/server/data/change/SnapshotData.java 90.00% <0.00%> (-10.00%) 0.00% <0.00%> (ø%)
...egistry/server/meta/store/SessionStoreService.java 56.59% <0.00%> (-9.35%) 0.00% <0.00%> (ø%)
...istry/server/meta/registry/MetaServerRegistry.java 66.66% <0.00%> (-9.10%) 0.00% <0.00%> (ø%)
...y/sofa/registry/server/data/change/ChangeData.java 58.33% <0.00%> (-8.34%) 0.00% <0.00%> (ø%)
...a/registry/task/scheduler/TimedSupervisorTask.java 65.51% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
...rver/session/node/service/DataNodeServiceImpl.java 60.55% <0.00%> (-6.67%) 0.00% <0.00%> (ø%)
...sofa/registry/server/meta/store/RenewDecorate.java 73.68% <0.00%> (-5.27%) 0.00% <0.00%> (ø%)
...ipay/sofa/registry/task/batcher/TaskExecutors.java 81.63% <0.00%> (-4.09%) 0.00% <0.00%> (ø%)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 505e36b...d447e68. Read the comment docs.

@nocvalight nocvalight closed this Oct 12, 2020
@nocvalight nocvalight reopened this Oct 12, 2020
@nocvalight nocvalight requested review from quhongwei and dzdx October 12, 2020 07:15
Copy link
Member

@dzdx dzdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nocvalight nocvalight merged commit fb22342 into sofastack:master Oct 12, 2020
dzdx added a commit that referenced this pull request Dec 13, 2021
* upgrade version to 5.4.4-SNAPSHOT

* clean log

Co-authored-by: dzdx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants