Refactor/api/simplify device update #5162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otavio
previously approved these changes
Aug 18, 2025
- Remove DeviceSetPosition from DeviceStore interface - Remove MongoDB implementation and tests - Remove mock generation for DeviceSetPosition method BREAKING CHANGE: removes DeviceSetPosition method from DeviceStore interface
- Remove DeviceUpdateStatus from DeviceStore interface - Remove MongoDB implementation and tests - Remove mock generation for DeviceUpdateStatus method BREAKING CHANGE: removes DeviceUpdateStatus method from DeviceStore interface
- Replace DeviceRename with DeviceUpdate in RenameDevice service - Remove complex validation logic and duplicate device checking - Use case-insensitive comparison for same name detection - Remove DeviceRename method from DeviceStore interface and implementations - Simplify test cases to focus on core functionality - Remove time import and device struct reconstruction BREAKING CHANGE: removes DeviceRename method from DeviceStore interface
heiytor
force-pushed
the
refactor/api/simplify-device-update
branch
from
0e269e8 to
a349531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.