feat(agent): deal with 429 and 503 HTTP status and Retry-After header #5146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrybarreto
force-pushed
the
feat/agent-too-many-requests-retry-after
branch
3 times, most recently
from
a05751a to
d0d0b8f
Compare
henrybarreto
changed the title
henrybarreto
force-pushed
the
feat/agent-too-many-requests-retry-after
branch
from
d0d0b8f to
f602cfb
Compare
This update introduces handling for the 429 and 503 HTTP status code, which indicates that the user has sent too many requests or the service is temporary unavailable in a time. The agent will now respect the Retry-After header, allowing for more efficient request management and reducing the likelihood of overwhelming the server. Additionally, the default retry time has been changed from 2 seconds to 5 seconds to provide a more reasonable wait time between retries, aligning with best practices for rate limiting and improving overall performance.
henrybarreto
force-pushed
the
feat/agent-too-many-requests-retry-after
branch
from
f602cfb to
5b9bab7
Compare
otavio
previously approved these changes
Aug 15, 2025
otavio
approved these changes
Aug 18, 2025
otavio
previously approved these changes
Aug 18, 2025
This commit enhances the client’s retry logic by replacing a fixed fallback wait time with a randomized interval whenever the server does not supply a Retry-After header. Instead of always pausing for 5 seconds, the code now computes a random duration between 5 seconds and 65 seconds. This change helps distribute retry attempts more evenly across clients, mitigating the risk of simultaneous reconnections (the “thundering herd” problem) when a service becomes available again.
henrybarreto
force-pushed
the
feat/agent-too-many-requests-retry-after
branch
from
b2eb7ed to
3e1b326
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces handling for the 429 HTTP status code, which indicates that the user has sent too many requests in a given amount of time. The agent will now respect the Retry-After header, allowing for more efficient request management and reducing the likelihood of overwhelming the server.
Additionally, the default retry time has been changed from 2 seconds to 5 seconds to provide a more reasonable wait time between retries, aligning with best practices for rate limiting and improving overall performance.