refactor: replace specific user getter methods with unified UserResolve #4946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `UserGetByID`, `UserGetByEmail`, and `UserGetByUsername` with a single `UserResolve` method that uses resolver patterns for better consistency and maintainability. - Add `UserResolver` enum with ID, Email, and Username resolvers - Implement `UserResolve` method in store with resolver-based querying - Update all service layers to use `UserResolve` instead of specific getters - Remove deprecated `UserGetByID`, `UserGetByEmail`, `UserGetByUsername` methods - Update all tests to use new `UserResolve` method calls - Fix test mocks to return correct number of values (remove extra int parameter) - Add comprehensive test coverage for UserResolve functionality
otavio
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
UserGetByID,UserGetByEmail, andUserGetByUsernamewith a singleUserResolvemethod that uses resolver patterns for better consistency and maintainability.UserResolverenum with ID, Email, and Username resolversUserResolvemethod in store with resolver-based queryingUserResolveinstead of specific gettersUserGetByID,UserGetByEmail,UserGetByUsernamemethodsUserResolvemethod calls