Skip to content

Conversation

luizhf42
Copy link
Member

@luizhf42 luizhf42 commented Jun 12, 2025

This pull request fixes some bugs in the admin's users panel, focusing on replacing the old confirmed boolean with a new status field for user confirmation states. It also includes updates to improve code clarity and consistency, such as the introduction of the UserStatusChip component for displaying user statuses and refactoring related logic.

  • Replaced the outdated and buggy confirmed boolean with a status field. Updated all related logic and UI components to use status instead of confirmed, fixing a related bug due to changes in the API.
  • Added UserStatusChip component to display user statuses in a standardized format across the UI.
  • Refactored the loginToken function to accept userId directly instead of a user object. Updated all references accordingly.
  • Improved type definitions by introducing UserAuthMethods and UserStatus types, and updated related logic for authentication methods and user preferences.
  • Updated unit tests to reflect the changes in user properties and added snapshot/tests for the new UserStatusChip component

@luizhf42 luizhf42 added this to the v0.19.x milestone Jun 12, 2025
@luizhf42 luizhf42 self-assigned this Jun 12, 2025
@luizhf42 luizhf42 force-pushed the fix/users-admin branch 2 times, most recently from 53452cb to 471172d Compare June 13, 2025 19:09
- fixes the typing of IUser, replacing outdated `confirmed` with `status`
- fixes the UI accordingly
- simplifies the status chip conditional logic
@luizhf42 luizhf42 force-pushed the fix/users-admin branch 7 times, most recently from ed505bb to 862290e Compare June 16, 2025 18:54
@luizhf42 luizhf42 marked this pull request as ready for review June 16, 2025 19:06
@luizhf42 luizhf42 requested a review from a team as a code owner June 16, 2025 19:06
@gustavosbarreto gustavosbarreto self-requested a review June 17, 2025 13:25
@gustavosbarreto gustavosbarreto merged commit 3699479 into master Jun 17, 2025
8 checks passed
@gustavosbarreto gustavosbarreto deleted the fix/users-admin branch June 17, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants