refactor(ui): refactor and rename BoxMessage.vue
#4912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this commit transforms `BoxMessage` into a dumb component. - now, instead of having logic, it's just used as a wrapper for the template - now the item, icon, content, and action button are passed by the parents
- removes the box.ts store since it became unnecessary
- now it truly reflects its purpose: be a message in a list that has no items
luizhf42
added
area/ui
kind/refactor
status/under-testing
luizhf42
force-pushed
the
refactor/box-message
branch
from
01c8606 to
c266714
Compare
luizhf42
added
status/needs-review
and removed
status/work-in-progress
status/under-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the
BoxMessagecomponent with a new, reusableNoItemsMessagecomponent. The changes streamline the code by removing redundant logic and improving maintainability. Additionally, theboxVuex store module and its related functionality have been removed as part of the cleanup.BoxMessagecomponent and its associated logic, and added a new reusableNoItemsMessagecomponent to display messages when no items are available. It uses slots for dynamic content and actions;boxVuex module, along with its references, since it was no longer in use;