Skip to content

fix(ssh): don't retry to save the session when http not acceptable is returned #4879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

fix(ssh): don't retry to save the session when http not acceptable is returned #4879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pkg/api/internalclient/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@ import (
"context"
"errors"
"fmt"
"net/http"

"github.com/gorilla/websocket"
"github.com/shellhub-io/shellhub/pkg/api/requests"
"github.com/shellhub-io/shellhub/pkg/models"
"github.com/sirupsen/logrus"
)

// sessionAPI defines methods for interacting with session-related functionality.
Expand Down Expand Up @@ -140,6 +142,15 @@ func (c *client) SaveSession(uid string, seat int) error {
switch {
case res.StatusCode() == 404:
return ErrNotFound
case res.StatusCode() == http.StatusNotAcceptable:
// NOTE: [http.StatusNotAcceptable] indicates that session's seat shouldn't be save, but also shouldn't
// represent an error.
logrus.WithFields(logrus.Fields{
"uid": uid,
"seat": fmt.Sprintf("%d", seat),
}).Debug("save session not acceptable")

return nil
case res.StatusCode() != 200:
return errors.New("failed to save the Asciinema due status code")
}
Expand Down
Loading