feat(ssh): simplify session, improve record, and record any PTY #4324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrybarreto
force-pushed
the
feat/ssh-simplify-and-record-performance
branch
from
335492e to
bc57d43
Compare
henrybarreto
changed the title
|
Beyond that, the record also works over exec operations with PTY. |
In previous refactoring, we have removed a bunch of operations from the server, letting both the parties communicate more freely. However, the session record kept doing the same blocking operations. The SSH server acts as an intermediary between the Agent and Client, so reducing communication overhead can significantly improve session performance and overall user experience. In a previous refactor, we reduced several blocking operations on the server, allowing for more efficient communication between the Agent and Client. However, the session record still relied on blocking operations, which limited performance. The core idea of this improvement was removing more operations over the communication between Agent and Client communication, and turning session record frame asynchronous using channels.
henrybarreto
force-pushed
the
feat/ssh-simplify-and-record-performance
branch
from
bc57d43 to
14c7180
Compare
henrybarreto
changed the title
|
@gustavosbarreto, do you think it is worth? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous refactoring, we have removed a bunch of operations from the server, letting both the parties communicate more freely. However, the session record kept doing the same blocking operations.
The SSH server acts as an intermediary between the Agent and Client, so reducing communication overhead can significantly improve session performance and overall user experience.
In a previous refactor, we reduced several blocking operations on the server, allowing for more efficient communication between the Agent and Client. However, the session record still relied on blocking operations, which limited performance.
The core idea of this improvement was removing more operations over the communication between Agent and Client communication, and turning session record frame asynchronous using channels.