Skip to content

fix: retrieve mm token by modality, raise error if none #8221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2025
Merged

fix: retrieve mm token by modality, raise error if none #8221

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e79db7d
fix: add method to retrieve token ID by modality in base processor an…
JustinTong0323 Jul 21, 2025
3933161
Merge branch 'main' into fix-base-processor-offset-calc-wrt-modality
JustinTong0323 Jul 21, 2025
bee995a
fix: add support for MULTI_IMAGES modality in token ID retrieval
JustinTong0323 Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions python/sglang/srt/multimodal/processors/base_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,13 @@ def get_modality_of_token(self, token: str) -> Optional[Modality]:

return None

def get_token_id_by_modality(self, modality: Modality) -> Optional[int]:
return {
Modality.IMAGE: self.image_token_id,
Modality.VIDEO: self.video_token_id,
Modality.AUDIO: self.audio_token_id,
}.get(modality)

def parse_regex(self):
if self.image_token_regex is None and self.image_token is not None:
self.image_token_regex = re.compile(re.escape(self.image_token))
Expand Down Expand Up @@ -608,14 +615,12 @@ def process_and_combine_mm_data(

# Add offsets to all items
for mm_item in all_collected_items:
mm_token_id = mm_tokens.get_token_id_by_modality(mm_item.modality)
if mm_token_id is None:
raise ValueError(f"No token id found for modality: {mm_item.modality}")
mm_item.offsets = self.get_mm_items_offset(
input_ids=input_ids,
mm_token_id={
Modality.IMAGE: mm_tokens.image_token_id,
Modality.MULTI_IMAGES: mm_tokens.image_token_id,
Modality.VIDEO: mm_tokens.video_token_id,
Modality.AUDIO: mm_tokens.audio_token_id,
}.get(mm_item.modality, None),
mm_token_id=mm_token_id,
)

return all_collected_items, input_ids, ret
Loading