-
Notifications
You must be signed in to change notification settings - Fork 4
Migrate logging implementation #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexandernorth
wants to merge
12
commits into
sdcio:main
Choose a base branch
from
alexandernorth:feature/logging-refactoring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migrate logging implementation #298
alexandernorth
wants to merge
12
commits into
sdcio:main
from
alexandernorth:feature/logging-refactoring
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
451677d
to
cfbba53
Compare
…r.Logger and passed through context
… name and using json for format
4553963
to
7f5e67a
Compare
bf6e4c4
to
c875f90
Compare
c875f90
to
c12e5ac
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to help with observability, this PR migrates the existing logging framework to a
logr.Logger
based one, which is passed to various functions through the context.This has the advantage that fields can be added to the logger as the application proceeds, adding relevant context to the log output and grouping together messages which belong to the same request/goroutine/...
It is also using structured logging which can help when integrating logs into observability tools.
This also refactors the netconf set function to have only one version of the code to handle setting to running or candidate stores, rather than two separate functions