Skip to content

Conversation

pan3793
Copy link

@pan3793 pan3793 commented Nov 27, 2019

Fixes #125

@eyalroth
Copy link
Contributor

Thank you for this fix. Looks like the cross-version test was broken (addressed in #127).

Could you edit the description to "Fixes #125"? It will make sure the ticket is closed once the PR is merged.

@pan3793
Copy link
Author

pan3793 commented Dec 1, 2019

@eyalroth Thanks for your guidance, description has been changed.

@maiflai
Copy link
Contributor

maiflai commented Dec 1, 2019

Thanks both.

Please can I confirm something though? I expected that merging @eyalroth's test change would break master, but it doesn't.

Is there still a missing test case?

I should have fixed this upstream as part of the 1.4.1 change, but I missed the opportunity.

Stu.

@eyalroth
Copy link
Contributor

eyalroth commented Dec 1, 2019

@maiflai I also expected my PR to not pass the checks. The changed test does fail on my machine, both when running from windows and linux (WSL), with either Oracle's JDK or OpenJDK.

Perhaps the check passes because it doesn't clean the project?

$ ./gradlew assemble
$ ./gradlew --info --stacktrace check

@eyalroth
Copy link
Contributor

eyalroth commented Dec 1, 2019

@maiflai Hmm I think the problem is actually that other functional tests are running before the cross-version test in the same JVM. I tried to remedy that in #128 by running the cross-version test before all the other functional tests. If my theory is correct, then #128 should now fail the check.

Edit: It fails, hooray!

@maiflai maiflai merged commit 544ef78 into scoverage:master Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v4.0.0 not compatible with Scala 2.11

3 participants