Support jsdom 27 #58
Merged
Support jsdom 27 #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japgolly
force-pushed
the
topic/jsdom27
branch
from
d7cb428 to
9779ca2
Compare
japgolly
force-pushed
the
topic/jsdom27
branch
4 times, most recently
from
b2a7b37 to
3969316
Compare
|
Rebasing on Please swap the order of the two commits. Otherwise the commit that adds jsdom 27 to the CI is a commit for which CI is broken. |
japgolly
force-pushed
the
topic/jsdom27
branch
from
3969316 to
06267e3
Compare
|
Thanks; done! PR is green now. |
sjrd
approved these changes
Sep 26, 2025
xerial
added a commit
to wvlet/wvlet
that referenced
this pull request
Sep 29, 2025
jsdom 27.0.0 introduced a breaking change where sendTo() was renamed to forwardTo() in VirtualConsole. This breaks scala-js-env-jsdom-nodejs 1.1.0 which still uses the old sendTo() API, causing TypeError during Scala.js test execution. The fix has been merged in scala-js/scala-js-env-jsdom-nodejs#58 but not yet released. Rollback jsdom to 26.1.0 until a new version of scala-js-env-jsdom-nodejs is released with jsdom 27 support. Fixes #1316 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
2 tasks
xerial
added a commit
to wvlet/wvlet
that referenced
this pull request
Sep 29, 2025
## Summary - Rollback jsdom from 27.0.0 to 26.1.0 to fix Scala.js test failures - jsdom 27.0.0 introduced breaking API change (sendTo() → forwardTo()) - scala-js-env-jsdom-nodejs 1.1.0 still uses old sendTo() API - Fix has been merged upstream but not yet released ## Problem PR #1316 upgraded jsdom from 26.1.0 to 27.0.0, which introduced a breaking change: - `VirtualConsole.sendTo()` was renamed to `forwardTo()` - This causes `TypeError: (intermediate value).sendTo is not a function` during Scala.js test execution - The error occurs because scala-js-env-jsdom-nodejs 1.1.0 (last released May 2020) still uses the old API ## Solution Rollback jsdom to 26.1.0 until scala-js-env-jsdom-nodejs releases a new version with jsdom 27 support. The fix has been merged in scala-js/scala-js-env-jsdom-nodejs#58 but not yet released. ## Test plan - [x] Run Scala.js tests locally: `./sbt "langJS/test"` - all 486 tests pass - [ ] CI Scala.js tests should pass ## Related Issues Fixes #1316 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude <[email protected]>
|
Hi guys, any news when a version with this PR will be released? |
carlosedp
added a commit
to carlosedp/zio-scalajs-stack
that referenced
this pull request
Oct 7, 2025
Downgrade jsdom dependency from version 27.0.0 to 26.1.0. This has to be kept until the lib is released with the scala-js/scala-js-env-jsdom-nodejs#58 PR.
|
Released as part of v1.1.1. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57