Skip to content

Add Query.get_meta() #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Query.get_meta() #299

wants to merge 1 commit into from

Conversation

chrisimcevoy
Copy link

Adds get_meta() to Query

closes #249

@chrisimcevoy
Copy link
Author

I'll take a look at the lint error.

@chrisimcevoy
Copy link
Author 

 + mypy tests typings
typings/django/db/models/sql/query.pyi:95:27: error: Missing type parameters for generic type "Options"  [type-arg]
Found 1 error in 1 file (checked 693 source files)

Interesting. Same return type as upstream.

The django-types Options uses the generic type parameter (_M) several times (source). I notice that django-stubs still has the generic type parameter on its Options, but it appears to be otherwise unused. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

db.models.sql.Query lacks get_meta() definition
1 participant
@chrisimcevoy