Update constaints for Django 5 #266
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, I've just checked and Would you prefer a cherry-pick of those as separate PRs? Or do you have any immediate plans to update from |
|
Could you mark this as ready for review? It might get some feedback on your questions way. I'm interested in this making it into this/pylance as well. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django 5 added:
BaseConstraint.violation_error_codeand corresponding__init__parameter.to replacecheckand correspondinginit` parameter.checknow emits a Django6 deprecation warning, but can't change it without updating the types.https://github.com/django/django/blob/stable/5.1.x/django/db/models/constraints.py