-
-
Notifications
You must be signed in to change notification settings - Fork 674
Developer Guide: Improve section on patching third-party packages #37485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vbraun
merged 3 commits into
sagemath:develop
from
mkoeppe:developer_guide_improve_patches_section
Mar 31, 2024
Merged
Developer Guide: Improve section on patching third-party packages #37485
vbraun
merged 3 commits into
sagemath:develop
from
mkoeppe:developer_guide_improve_patches_section
Mar 31, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add subsection on importing patch from GitHub PR
kwankyu
reviewed
Mar 26, 2024
kwankyu
reviewed
Mar 26, 2024
kwankyu
reviewed
Mar 26, 2024
kwankyu
reviewed
Mar 26, 2024
kwankyu
reviewed
Mar 26, 2024
kwankyu
reviewed
Mar 26, 2024
kwankyu
reviewed
Mar 26, 2024
Documentation preview for this PR (built with commit a69a466; changes) is ready! 🎉 |
kwankyu
reviewed
Mar 28, 2024
kwankyu
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The subsections on patching are now consolidated in a subsection "Modifying third-party code".
There is new material on importing PRs from GitHub
📝 Checklist
⌛ Dependencies