Downloading multiple worksheets does not work

[jasongrout]

I do the following:

1. Start the notebook with notebook()

2. click the checkboxes next to a few worksheets

3. hit the "Download" button

and I get an error:

The resource /download_worksheets?filenames=admin/77___S_A_G_E___admin/76___S_A_G_E___admin/75___S_A_G_E___&sep=___S_A_G_E___ cannot be found.

CC: @TimDumol @jasongrout

Component: notebook

Author: Mitesh Patel

Reviewer: Alex Leone

Merged: sagenb-0.7

Issue created by migration from https://trac.sagemath.org/ticket/7963

[jasongrout]

Description changed:

--- 
+++ 
@@ -1,7 +1,9 @@
 I do the following:
 
 1. Start the notebook with `notebook()`
+
 2. click the checkboxes next to a few worksheets
+
 3. hit the "Download" button
 
 and I get an error:

[qed777]

comment:2

I think this is a matter of

--- a/sagenb/data/sage/js/notebook_lib.js
+++ b/sagenb/data/sage/js/notebook_lib.js
@@ -1515,7 +1515,7 @@ function download_worksheets_button() {
     /*
     Downloads the set of checked worksheets as a zip file.
     */
-    window.location.replace("/download_worksheets?filenames=" +
+    window.location.replace("/download_worksheets.zip?filenames=" +
                             checked_worksheet_filenames() + "&sep=" + SEP);
 }

but I haven't posted a patch, since #7908 and some of its dependencies make a lot of changes to notebook_lib.js.

[TimDumol]

Adds mpatel's suggested fix.

[TimDumol]

comment:3

Attachment: trac_7963-download-multiple-worksheets.patch.gz

This adds what mpatel suggested.

[qed777]

comment:4

Thanks for making a patch! It works for me, but I'm not sure I should review this by myself.

[sagetrac-acleone]

Reviewer: Alex Leone

[sagetrac-acleone]

Author: Mitesh Patel

[sagetrac-acleone]

comment:5

LGTM.